RFR (S): 8245509: Crash handler itself crashes when reporting Unsafe.putInt(0) crash

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Mon Jun 1 21:21:12 UTC 2020

On 6/1/20 3:57 PM, gerard ziemski wrote:
> hi Coleen,
> On 6/1/20 1:33 PM, coleen.phillimore at oracle.com wrote:
>> In rev2, in the second part, can you move the ResourceMark just out 
>> of the loop?  Otherwise, looks good and I don't need to see another 
>> webrev. 
> I thought the ResourceMark should go with the operation it's meant 
> for, to make the code more self documenting.
> Why does it need to go outside pf the loop? To minimize number of 
> allocations?

It sets an allocation marker in the Arena to allocate from in the 
current thread.  It's a pretty cheap operation, and it's for error 
handling, so it can go inside the loop.  Your change is fine.


> cheers

More information about the hotspot-runtime-dev mailing list