RFR(S): 8246377: [PPC64] Further improvements for assembler stop function

Liu, Xin xxinliu at amazon.com
Tue Jun 2 23:56:21 UTC 2020

Hi, Martin, 

I read it and it looks good to me, but it still needs a real reviewer approve. 

You actually make TDI a variable-length instruction.  Why not just emit "(uintptr_t)msg" no matter what?   
Particularly, "enum stop_msg_present = -0x8000" is correct but subtle.  I'd like to learn from other reviewers. 


From: "Doerr, Martin" <martin.doerr at sap.com>
Date: Tuesday, June 2, 2020 at 3:35 PM
To: hotspot-runtime-dev <hotspot-runtime-dev at openjdk.java.net>, "Schmidt, Lutz" <lutz.schmidt at sap.com>, "Andrew Haley (aph at redhat.com)" <aph at redhat.com>, "Liu, Xin" <xxinliu at amazon.com>
Subject: [EXTERNAL] RFR(S): 8246377: [PPC64] Further improvements for assembler stop function

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.

I’d like to have the improvements which we discussed for AArch64 also on PPC64 (+ a little more).
Issue with details:
Please review.
Best regards,

More information about the hotspot-runtime-dev mailing list