RFR: 8246837: Rename WeakHandle<vm_class_loader_data> to better reflect its OopStorage association

Erik Österlund erik.osterlund at oracle.com
Tue Jun 9 13:12:37 UTC 2020

Hi Coleen,

Thanks for the review, and thanks for saying it is trivial.


On 2020-06-09 13:34, coleen.phillimore at oracle.com wrote:
> This looks great.  Thanks for fixing the name.  This is trivial and 
> doesn't need another review.
> Coleen
> On 6/9/20 4:11 AM, Erik Österlund wrote:
>> Hi,
>> WeakHandle<vm_class_loader_data> uses the OopStorageSet::vm_weak() 
>> OopStorage. This is not obvious from the name. In particular, it 
>> becomes problematic when new weak handles are created in other areas 
>> of the VM, using the same OopStorage. I don't want them to go under 
>> the vm_class_loader_data name, when they have nothing to do with 
>> that. It seems more intuitive to name them vm_weak_data, reflecting 
>> which OopStorage they are associated with.
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8246837
>> Webrev:
>> http://cr.openjdk.java.net/~eosterlund/8246837/webrev.00/
>> Thanks,
>> /Erik

More information about the hotspot-runtime-dev mailing list