RFR: 8271514: support JFR use of new ThreadsList::Iterator

David Holmes dholmes at openjdk.java.net
Mon Aug 2 04:35:31 UTC 2021

On Fri, 30 Jul 2021 20:20:48 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

> A trivial fix to support JFR use of new ThreadsList::Iterator.
> This fix was tested with Mach5 Tier[1-3].

Hi Dan,

I'm assuming that the intent of this conversion is that `JavaThreadIteratorWithHandle` is going to be removed - is that right?

The conversion seems okay but definitely not a trivial change IMO. And a query below before I can approve this.


src/hotspot/share/jfr/utilities/jfrThreadIterator.hpp line 50:

> 48: class JfrJavaThreadIteratorAdapter {
> 49:  private:
> 50:   ThreadsListHandle _tlist;

Why do we need to store this?

It looks very suspiocious to have a member that is a stackObj, in a class that is not itself a stackObj. ??


PR: https://git.openjdk.java.net/jdk/pull/4949

More information about the hotspot-runtime-dev mailing list