RFR: 8271003: hs_err improvement: handle CLASSPATH env setting longer than O_BUFLEN [v2]

Thomas Stuefe stuefe at openjdk.java.net
Tue Aug 3 17:18:29 UTC 2021

On Tue, 3 Aug 2021 16:14:57 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Please review this small enhancement for addressing the problem of the CLASSPATH env variable setting being truncated in a hs err log.
>> For printing a char string, it doesn't need to go through `do_vsnprintf()` which does the truncation based on the input buffer length. The change is local to the code path pertaining to hs err log.
>> Testing:
>> - [x] tiers 1, 2 (including the new test)
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>   @tstuefe comments

Looks good, Calvin. Your more general approach would have been nice, but thanks for considering my log tearing worries and for taking my suggestion.

Cheers, Thomas


Marked as reviewed by stuefe (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4947

More information about the hotspot-runtime-dev mailing list