RFR: 8271891: mark hotspot runtime/Safepoint tests which ignore external VM flags

Igor Ignatyev iignatyev at openjdk.java.net
Wed Aug 4 19:50:34 UTC 2021

On Wed, 4 Aug 2021 19:36:50 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Hi all,
>> please review this small patch that `@requires vm.flagless` to `runtime/Safepoint` tests.
>> Thanks,
>> -- Igor
> test/hotspot/jtreg/runtime/Safepoint/TestAbortOnVMOperationTimeout.java line 31:
>> 29:  * @bug 8181143 8269523
>> 30:  * @summary Check abort on VM timeout is working
>> 31:  * @requires vm.flagless
> So it's essentially the driver tests - ie tests that call process builder to run the test that need this?

there are two kind of tests that can/should have `vm.flagless`:
 - 1st, the driver tests that don't pass external flags to a child JVM, in that case, it's useless to run the test w/ any external flags as you won't get any signal and just waste time
 - 2nd, tests that aren't designed to be run w/ external flags, tests that highly depend on JVM configuration to the extent that the majority of configurations make such tests inapplicable, e.g. jfr tests.

all the tests which I'm marking in [8246498](https://bugs.openjdk.java.net/browse/JDK-8246498) sub-tasks are of the first kind.


PR: https://git.openjdk.java.net/jdk/pull/5000

More information about the hotspot-runtime-dev mailing list