RFR: 8271905: mark hotspot runtime/Metaspace tests which ignore external VM flags
thomas.stuefe at gmail.com
Thu Aug 5 05:56:29 UTC 2021
Ah, thanks a lot for the reminder. Makes sense then.
On Thu, Aug 5, 2021 at 7:48 AM David Holmes <david.holmes at oracle.com> wrote:
> Hi Thomas,
> On 5/08/2021 2:35 pm, Thomas Stuefe wrote:
> > On Wed, 4 Aug 2021 22:56:25 GMT, Igor Ignatyev <iignatyev at openjdk.org>
> >> Hi all,
> >> could you please review the patch that adds `@requires vm.flagless` to
> two `runtime/Metaspace` tests?
> >> Thanks,
> >> -- Igor
> > Hi Igor,
> > I know we spoke about this before, but could you please explain again
> the motivation for these changes? Is this flag somewhere documented?
> > AFAIU the flag changes the test such that it gets not executed by the
> jtreg framework if I specify a VM option on the command line with -vmoption
> (apart from a very narrow range of allowed options)?
> > I often run jtreg tests with additional options to exercise tests in
> different contexts. Having them quietly turn off themselves would not be
> helpful then.
> These tests exec another VM which is not passed the flags you set so
> setting them provides no additional testing of the core thing the test
> is actually testing.
> > Thanks, Thomas
> > -------------
> > PR: https://git.openjdk.java.net/jdk/pull/5010
More information about the hotspot-runtime-dev