RFR: 8263567: gtests don't terminate the VM safely [v2]

Thomas Stuefe stuefe at openjdk.java.net
Fri Aug 6 05:08:29 UTC 2021

On Fri, 6 Aug 2021 04:34:40 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> test/hotspot/gtest/gtestMain.cpp line 220:
>>> 218: 
>>> 219: // This is generally run once for a set of tests, but if we have vm_assert, or other_vm
>>> 220: // tests, a new process is forked and this will be called, for each of those tests.
>> is the comma needed?
> Which one? :) I wanted to convey that the fork and execution of `runUnitTestsInner` is done for each test. I will reword and restructure.

The second one after "called" tickled my comma sense. But I am not a native speaker and may be wrong.


PR: https://git.openjdk.java.net/jdk/pull/4986

More information about the hotspot-runtime-dev mailing list