RFR: 8271931: Make AbortVMOnVMOperationTimeout more resilient to OS scheduling [v2]
shade at openjdk.java.net
Fri Aug 6 15:30:30 UTC 2021
On Fri, 6 Aug 2021 12:01:49 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Perform VM-op timeout also on the VM thread. If a VM-op is stuck, the existing watcher-thread based machinery will kick in and detect it.
>> Test: tier1
> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
Yeah, that looks fine. I have two minor suggestions.
src/hotspot/share/runtime/vmThread.cpp line 93:
> 91: fatal("%s VM operation took too long: completed in " JLONG_FORMAT " ms (timeout: " INTX_FORMAT " ms)",
> 92: _vm_op_name, vm_op_duration, AbortVMOnVMOperationTimeoutDelay);
> 93: }
Should we null `_vm_op_name` here?
src/hotspot/share/runtime/vmThread.hpp line 42:
> 40: volatile int _armed;
> 41: jlong _arm_time;
> 42: const char* _vm_op_name = nullptr;
Style question: are we doing these inits inline, instead of constructor?
Marked as reviewed by shade (Reviewer).
More information about the hotspot-runtime-dev