RFR: 8260262: Use common code in function unmap_shared() in perfMemory_posix.cpp
stuefe at openjdk.java.net
Mon Aug 9 08:10:34 UTC 2021
On Wed, 4 Aug 2021 17:15:46 GMT, Harold Seigel <hseigel at openjdk.org> wrote:
> Please review this change to use common code in function unmap_shared() in perfMemory_posix.cpp, to fix JDK-8260262. The change calls munmap() directly to deallocate the memory because functions mmap_create_shared() and mmap_attach_shared() call mmap() directly to allocate the memory.
> The change was tested by running Mach5 tiers 1-2 on Linux, MacOS, and Windows, and Mach5 tiers 3-5 on Linux x64 and MacOS x64.
> Note that testing on AIX is needed.
> Thanks, Harold
thank you for doing this. The patch looks fine to me.
About AIX testing, SAP started to withdraw from AIX development and IBM will take a bigger role in the long run. One of the effects of that decision is that we gave up our AIX CI for OpenJDK head. I still can build and test manually if necessary, but let's first see if IBM has their AIX test systems up yet.
@tellison, could you guys test this or should I do this?
Marked as reviewed by stuefe (Reviewer).
More information about the hotspot-runtime-dev