[jdk17] RFR: 8272472: StackGuardPages test doesn't build with glibc 2.34 [v2]

Jie Fu jiefu at openjdk.java.net
Mon Aug 16 01:51:37 UTC 2021

On Mon, 16 Aug 2021 01:43:45 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Please review this simple test fix to address an issue that will prevent the JDK 17 test sources from building on more recent Linux distributions with Glibc 2.34. When building under _GNU_SOURCE the value of SIGSTKSZ is no longer a constant and so cannot be used in an array declaration. The simple fix is to malloc the array instead.
>> This is a PR against 17 pending a decision as to whether this needs to, and can be, addressed in 17. If not then this PR will be withdrawn and resubmitted against 18 with a backport to 17u.
>> Testing: local & mach5 tiers 1-3
>> Thanks,
>> David
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>   Review feedback - minor updates

Looks good to me.

I'd like this fix goes into jdk17 since it's a build error and only affects test code.


Marked as reviewed by jiefu (Reviewer).

PR: https://git.openjdk.java.net/jdk17/pull/304

More information about the hotspot-runtime-dev mailing list