RFR: 8272291: mark hotspot runtime/logging tests which ignore external VM flags
dholmes at openjdk.java.net
Tue Aug 17 02:04:25 UTC 2021
On Tue, 10 Aug 2021 20:03:52 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:
> Hi all,
> could you please review the patch that adds `@requires vm.flagless` to 23 hotspot runtime/logging tests that ignore external VM flags?
> -- Igor
There are a couple of changes to existing @requires that I don't agree with. Otherwise all seems okay.
test/hotspot/jtreg/runtime/logging/ClassLoadUnloadTest.java line 28:
> 26: * @test ClassLoadUnloadTest
> 27: * @bug 8142506
> 28: * @requires vm.opt.final.ClassUnloading
The new requirement is weaker than the old. If ClassUnloading were not enabled by default then this test would now run when it should not.
test/hotspot/jtreg/runtime/logging/CompressedOopsTest.java line 28:
> 26: * @bug 8149991
> 27: * @requires vm.bits == 64
> 28: * @requires vm.flagless
Similar comment here, you have weakened the condition that enables the test.
Changes requested by dholmes (Reviewer).
More information about the hotspot-runtime-dev