RFR: 8272291: mark hotspot runtime/logging tests which ignore external VM flags [v2]

Igor Ignatyev iignatyev at openjdk.java.net
Tue Aug 17 03:30:53 UTC 2021

On Tue, 17 Aug 2021 01:56:09 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Igor Ignatyev has updated the pull request incrementally with one additional commit since the last revision:
>>   added -XX:+ClassUnloading in logging/ClassLoadUnloadTest.java
> test/hotspot/jtreg/runtime/logging/ClassLoadUnloadTest.java line 28:
>> 26:  * @test ClassLoadUnloadTest
>> 27:  * @bug 8142506
>> 28:  * @requires vm.opt.final.ClassUnloading
> The new requirement is weaker than the old. If ClassUnloading were not enabled by default then this test would now run when it should not.

nice catch, I guess I assumed that the test makes sure its child JVMs are run in the correct setting (as `CompressedOopsTest.java` does). I'll update the test to pass `-XX:+ClassUnloading` in `ClassLoadUnloadTest::exec`.

> test/hotspot/jtreg/runtime/logging/CompressedOopsTest.java line 28:
>> 26:  * @bug 8149991
>> 27:  * @requires vm.bits == 64
>> 28:  * @requires vm.flagless
> Similar comment here, you have weakened the condition that enables the test.

this test explicitly passes `-XX:+UseCompressedOops` to a child JVM, so the condition hasn't been weakened, if anything this change increases the coverage for JVMs where `UseCompressedOops` isn't true by default as now the test will be included in out-of-box runs.


PR: https://git.openjdk.java.net/jdk/pull/5075

More information about the hotspot-runtime-dev mailing list