RFR: 8272472: StackGuardPages test doesn't build with glibc 2.34

David Holmes dholmes at openjdk.java.net
Sun Aug 22 01:14:42 UTC 2021

On Sat, 21 Aug 2021 13:34:35 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Please review this simple test fix to address an issue that will prevent this test source from building on more recent Linux distributions with Glibc 2.34. When building under _GNU_SOURCE the value of SIGSTKSZ is no longer a constant and so cannot be used in an array declaration. The simple fix is to malloc the array instead.
>> Testing: local & mach5 tiers 1-3
>> Thanks,
>> David
> Looks good. Leaking is fine here I think. I was confused about not having to cast till I remembered this is C.

Thanks for the review @tstuefe


PR: https://git.openjdk.java.net/jdk/pull/5200

More information about the hotspot-runtime-dev mailing list