RFR: 8272553: several hotspot runtime/CommandLine tests don't check exit code

David Holmes dholmes at openjdk.java.net
Mon Aug 23 05:08:26 UTC 2021

On Thu, 19 Aug 2021 19:21:36 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

> Hi all,
> could you please review this patch that adds exit code check to several hotspot `runtime/CommandLine` tests?
> Thanks,
> -- Igor

Hi Igor,

One test already has the check, but otherwise okay.


test/hotspot/jtreg/runtime/CommandLine/ConfigFileWarning.java line 53:

> 51:         output.shouldNotHaveExitValue(0);
> 52:         output.shouldContain("Unrecognized VM option 'aaa'");
> 53:         output.shouldHaveExitValue(1);

We are already testing the exit code.


Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5191

More information about the hotspot-runtime-dev mailing list