RFR: 8272884: Make VoidClosure::do_void pure virtual

Kim Barrett kbarrett at openjdk.java.net
Tue Aug 24 08:05:32 UTC 2021

On Tue, 24 Aug 2021 07:40:00 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Simple change of making VoidClosure::do_void pure virtual.
> Test: build

Looks good in principle.

But it seems like this needs more testing than just a successful build, to
account for the "breaks in mysterious ways" comment. That comment and pure
virtual avoidance goes back to before mercurial, so might no longer be
relevant (ancient compiler bugs? other problems?). But I don't think just a
successful build tells us that. Though I admit I don't have any theories about
what could go wrong, or even expectations that something will. So I'm
conditionally approving, assuming it passes additional testing, like run a
couple of tiers in our CI.


Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5237

More information about the hotspot-runtime-dev mailing list