RFR: 8272811: Document the effects of building with _GNU_SOURCE in os_posix.hpp
sgehwolf at openjdk.java.net
Wed Aug 25 08:54:23 UTC 2021
On Tue, 24 Aug 2021 16:58:00 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> Please review this trivial code documentation enhancement based on discussions here:
> Shouldn't something along those lines also be mentioned where it's actually defined? Like:
> @jerboaa thanks for taking a look. I initially planned to document it in the makefiles somewhere but then found that we don't document why we use any flags there :( Plus there are a number of places where -D_GNU_SOURCE is used and I only want to document the reasoning for the VM which would then beg the question is to why the other uses are not documented somehow. So I just put it in os_posix.hpp where it was more likely to be seen when needed.
More information about the hotspot-runtime-dev