RFR: 8269373: some tests in jdk/tools/launcher/ fails on localized Windows platform [v2]
myano at openjdk.java.net
Thu Aug 26 06:57:31 UTC 2021
On Wed, 4 Aug 2021 07:25:06 GMT, Masanori Yano <myano at openjdk.org> wrote:
>> Hi all,
>> Could you please review the 8269373 bug fixes?
>> These tests call java.lang.ProcessBuilder in direct, so not used jtreg command option. To run non-localized tests, -Duser.language=en and -Duser.country=US options should be added in ProcessBuilder.
> Masanori Yano has updated the pull request incrementally with one additional commit since the last revision:
> 8269373: use test opts for process arguments
I think the current tests force the US locale, and false positives are test failures in non-US locale environments. This fix does not change the test results in the US locale, but allows it to work in non-US locale environments.
I can't think of a false positive problem with this fix, but what specific cases do you think are the problems?
More information about the hotspot-runtime-dev