RFR: 8269373: some tests in jdk/tools/launcher/ fails on localized Windows platform [v2]

Naoto Sato naoto at openjdk.java.net
Thu Aug 26 19:05:29 UTC 2021

On Wed, 4 Aug 2021 07:25:06 GMT, Masanori Yano <myano at openjdk.org> wrote:

>> Hi all,
>> Could you please review the 8269373 bug fixes?
>> These tests call java.lang.ProcessBuilder in direct, so not used jtreg command option. To run non-localized tests, -Duser.language=en and -Duser.country=US options should be added in ProcessBuilder.
> Masanori Yano has updated the pull request incrementally with one additional commit since the last revision:
>   8269373: use test opts for process arguments

I think implicitly expecting locales to be set to en-US by specifying `test.vm.opts` is fragile which would introduce test instability.
In fact, looking at some of the tests, e.g., `HelpFlagsTest` at line 332, the intention is to silently exit in case it is not English. I think it is what the test is intended and it is a bug if it fails with other locales.


PR: https://git.openjdk.java.net/jdk/pull/4594

More information about the hotspot-runtime-dev mailing list