RFR: 8274282: Clarify special wait assert [v2]

Coleen Phillimore coleenp at openjdk.java.net
Mon Oct 4 13:16:34 UTC 2021

On Wed, 29 Sep 2021 04:26:32 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.
> src/hotspot/share/runtime/mutex.cpp line 389:
>> 387:     // We enforce not holding locks of rank nosafepoint or lower while waiting for JavaThreads,
>> 388:     // because the held lock has a NoSafepointVerifier so waiting on a lock will block out safepoints.
>> 389:     // For NonJavaThreads, we enforce not waiting on the tty lock since that could block progress also.
> You are checking this for all threads not just NJTs. Is the comment wrong or the code?

I could start the comment like, For JavaThreads, we enforce not holding ... and leave the For NonJavaThreads ...


PR: https://git.openjdk.java.net/jdk/pull/5684

More information about the hotspot-runtime-dev mailing list