RFR: 8274282: Clarify special wait assert [v4]

Patricio Chilano Mateo pchilanomate at openjdk.java.net
Tue Oct 5 15:03:37 UTC 2021

On Mon, 4 Oct 2021 14:05:35 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This change removes the assert and tests for Mutex::wait() only allowed with greater than nosafepoint ranked held locks.
>> Tested with tier1-3.
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>   Update comment, maybe clearer?

LGTM! Only small comment below.


src/hotspot/share/runtime/mutex.cpp line 390:

> 388:     // because the held lock has a NoSafepointVerifier so waiting on a lower ranked lock will not be
> 389:     // able to check for safepoints first with a TBIVM.
> 390:     // For all threads, we enforce not waiting on the tty lock since that could block progress also.

I think this should be s/on the tty lock/while holding the tty lock or below.


Marked as reviewed by pchilanomate (Committer).

PR: https://git.openjdk.java.net/jdk/pull/5684

More information about the hotspot-runtime-dev mailing list