RFR: JDK-8276039: typo: java_lang_Class:set_init_lock() should be java_lang_Class::set_init_lock()

Kim Barrett kbarrett at openjdk.java.net
Wed Oct 27 20:24:12 UTC 2021

On Wed, 27 Oct 2021 04:41:03 GMT, Yumin Qi <minqi at openjdk.org> wrote:

> Please review,
>   I have no idea why this problem has not been encountered in compilation, it is obvious the usage of resolution operator :: is not complete and wrong.
>  Tests: mach5 tier1, tier4
> Thanks
> Yumin

Changes requested by kbarrett (Reviewer).

src/hotspot/share/classfile/javaClasses.cpp line 1264:

> 1262:     InstanceKlass::cast(k)->do_local_static_fields(&reset);
> 1263: 
> 1264:     java_lang_Class::set_init_lock(archived_mirror, NULL);

Rather than fixing the qualification, I would just drop the qualification completely, being consistent with most of the other similar calls in this function, including several that immediately follow.


PR: https://git.openjdk.java.net/jdk/pull/6130

More information about the hotspot-runtime-dev mailing list