RFR: JDK-8276039: Remove unnecessary qualifications of java_lang_Class:: [v2]

David Holmes david.holmes at oracle.com
Fri Oct 29 21:28:10 UTC 2021

Hi Yumin,

On 30/10/2021 2:16 am, Yumin Qi wrote:
> On Wed, 27 Oct 2021 05:20:37 GMT, Mikael Vidstedt <mikael at openjdk.org> wrote:
>>> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
>>>    Remove unnecessary qualifier scope operator in class java_lang_Class
>> That's funny. I guess `java_lang_Class:` becomes a label and set_init_lock is local to the class so resolution works anyway.
> @vidmik @iklam Thanks for review
> @dholmes-ora @kimbarrett Thanks for comment

This was not properly reviewed IMO. The "reviews" from Mikael and Ioi 
were for the initial one-line change. Then based on the comments you 
made much more extensive changes. Those extensive changes were not 
actually approved by anyone. I was waiting for the bug and PR titles to 
get updated.


> -------------
> PR: https://git.openjdk.java.net/jdk/pull/6130

More information about the hotspot-runtime-dev mailing list