<i18n dev> [8] Code review request: 8000983 and 8003267

Naoto Sato naoto.sato at oracle.com
Thu Dec 6 12:49:39 PST 2012

Here are my comments:

- Bundle.java

Line 277,297: Do we need two separate iteration loops here? Two 
iteration loops look like the same.

Line 303: typo "paris"

Line 606: typo "Someting"

Line 728: Could use foreach here.

- CLDRConverter.java

Line 388: The FormatData bundle is now "OPEN", which used to be "PLAIN"?

- FormatData_xx.java

Line: xxx: In some resource bundles, the array for DayNarrows duplicates 
other array. Can be combined with it like in FormatData.java 
buddhist/japanese ones.

- CalendarNameProviderImpl.java

Line 84: The int[] can be statically created.

- LocaleResources.java

Line 74: Variable name "olrb" stands for OpenListResourceBundle, so 
"tznb" would better fit here.


On 12/5/12 9:06 PM, Masayoshi Okutsu wrote:
> Resending in order to include build-dev at openjdk.java.net and
> build-infra at openjdk.dev.java.net.
> Hi,
> This is a review request for two RFEs.
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000983
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003267
> http://cr.openjdk.java.net/~okutsu/8/8000983.8003267/webrev.00/
> I haven't added generic time zone names to the JRE resources except for
> the "en" resources. I've filed another RFE for this item (JDK-8004278).
> Thanks,
> Masayoshi

More information about the i18n-dev mailing list