<i18n dev> RFR: 7017818 NLS: JConsoleResources.java cannot be handled by translation team
michael.fang at oracle.com
Tue May 22 12:58:34 PDT 2012
I have already downloaded the raw message.properties file from the
webrev on 5/16 to proceed with the 7u6 translation.
I performed a diff with current webrev, and it consists of mostly
deleted resources and 1 renamed key CONNECTION_LOST1 => CONNECTION_LOST.
I am fine with the changes from l10n perspective.
On 12?05?21? 04:18 ??, Erik Gahlin wrote:
> Thanks Michael,
> When it comes to ALL CAPs or SturdlyCaps, it's okay if those strings
> are not translated.
> Here is an updated webrev. I removed strings that were no longer in
> use and made some changes to the make-files.
> Michael Fang skrev 2012-05-11 18:16:
>> Thanks so much Erik for the fix! The messages.properties file look
>> good. I only reviewed the English *messages.properties* file. WPTG
>> will re-translate the ja and zh_CN files. They will attempt to
>> leverage existing translation from *JConsoleResources_xx.java*.
>> I have a comments about another translatability rule that WPTG follows:
>> By Oracle software development guideline, ALL CAPs or StudlyCaps
>> strings will not be translated. Examples are:
>> 19 ACTION_CAPITALIZED=ACTION
>> 20 ACTION_INFO_CAPITALIZED=ACTION_INFO
>> 149 MBEAN_INFO=MBeanInfo
>> 150 MBEAN_NOTIFICATION_INFO=MBeanNotificationInfo
>> 151 MBEAN_OPERATION_INFO=MBeanOperationInfo
>> 206 OBJECT_NAME=ObjectName
>> 231 R_FORWARD_SLASH_W_CAPITALIZED=R/W
>> 241 SEQ_NUM=SeqNum
>> 249 SUMMARY_TAB_HEADER_DATE_TIME_FORMAT=FULL,FULL
>> 273 UNKNOWN_CAPITALIZED=UNKNOWN
>> If any of the above such as ACTION or UNKNOWN needs to be translated,
>> they should not be ALL CAPS. The translators will not translate those
>> lines by default.
>> The translators have the ability to see comments (or special
>> requests) if a comment line is inserted immediately prior to any of
>> the resources (each resource string and one comment line immediately
>> before it is stored in translation memory). If you must leave ACTION
>> or UNKNOWN in CAPS, you can try to insert comments.However, WPTG does
>> not guarantee they will be followed.
>> On 12?05?11? 07:36 ??, Erik Gahlin wrote:
>>> Could you please review? I also need a sponsor.
>>> The patch is for JDK8, but it needs to ported to 7u6 before 5/16.
>>> - Moved localization messages to property files, one message per
>>> line, as needed.
>>> - Added '&' to messages so mnemonics could be identified.
>>> - Introduced Message class with static fields corresponding to the
>>> keys in the property files.
>>> - Added map for looking up mnemonics.
>>> - Verified programmatically that all the messages and mnemonics are
>>> "compatible" with the previous mechanism, for Chinese, Japanese and
>>> the default locale.
>>> - The intention is to run through the GUI to confirm that everything
>>> looks ok, but I'm waiting for a build.
>>> - Fixed a typo in the MemoryPoolStat class, the method
>>> getAfterGcUsage returned this.beforeGCUsage instead of
>>> - When going through all the code I did some minor clean up that
>>> should not impact the program flow:
>>> * removed unused imports.
>>> * inlined temporary variables holding messages.
>>> * removed private member variables that were not accessed.
>>> * removed private methods that were not referenced.
>>> * removed local variables that were not used.
>>> * added generic types where needed.
>>> * static methods are now called statically.
>>> * added suppress serialization warning where it was needed.
>>> * removed suppress serialization annotation where it was not needed.
>>> - In the Message class, the comment "remove? not found in code" will
>>> be removed once I know those message are not needed for 7u6.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the i18n-dev