<i18n dev>  Request for review: 8029239: jdk8 l10n resource file translation update - localenames
masayoshi.okutsu at oracle.com
Wed Dec 4 01:17:52 PST 2013
I still don't like the unnecessary case changes for the \uxxxx notation,
which makes code review very difficult (even UTF-8 ones).
I noticed the following change uses '=' (the second one) as a word
delimiter. This looks strange to me.
Should the bug# be added to test/sun/text/resources/LocaleDataTest.java
when LocaleData has been modified?
On 12/4/2013 1:02 PM, Michael Fang wrote:
> I have updated the webrev
> 2 failed regression tests have been addressed:
> Mismatch in LocaleNames/pt/wa:
> file = "val\\\\u00e3o"
> jvm = "val\\u00e3o"
> Mismatch in LocaleNames/pt/FM:
> file = "Micron\\\\u00e9sia"
> jvm = "Micron\\u00e9sia"
> Test failed. 2 errors.
> On 13年12月03日 05:10 下午, Michael Fang wrote:
>> Please help to review the changes for the following CR:
>> The webrev is available here:
>> The changes included the following:
>> Portuguese files were updated with resources generated from CLDR 2.1.
>> LocaleNames_pt_BR.properties have been removed as a result.
>> Regression tests were performed and failed tests were updated to be
>> compatible with the changes to CLDR 2.1.
>> There are also translation capitalization changes. I did some
>> research about capitalization rules and found that for Spanish,
>> French, Italian, Portuguese, and Swedish, language names are not
>> capitalized, but country names are and these are consistent with CLDR
>> as well.
>> References about capitalization
>> es, fr, it, sv, pt, etc
>> French: http://french.about.com/library/writing/bl-capitalization.htm
>> Italian: http://www.translationdirectory.com/article714.htm
>> Swedish: http://en.wikibooks.org/wiki/Swedish/Nationalities
>> There are also translation changes performed by translators. I
>> reviewed each change against CLDR. I only accepted the changes that's
>> consistent with CLDR since I don't know the languages and could only
>> use CLDR as a reference.
>> I did not add new regression tests for the translation changes since
>> there are no formatting changes, just translation changes. We have a
>> keyword noreg-l10n that covers the exception for requiring regression
>> tests for translation changes.
More information about the i18n-dev