<i18n dev> Review request for 8004240
naoto.sato at oracle.com
Mon Feb 25 15:34:23 PST 2013
(modified the title)
OK, so this is the review request for 8004240 fix. I changed the type of
'adapterPreference' from 'Type' to 'List<Type>' and initialized it
with the 'unmodifiableList'.
On 2/25/13 11:13 AM, Naoto Sato wrote:
> Thank you for the review. Please see my comments embedded below.
> On 2/24/13 6:16 PM, Masayoshi Okutsu wrote:
>> For 8004240, I think adapterPreference should be changed to an
>> unmodifiable List because getAdapterPreference() is called often.
> Agree. Will change the impl.
>> For 8008577, I think it's a spec change to 6336885, and that CCC
>> approval is required. And should the CLDR adapter be initialized and be
>> removed from the list if the initialization failed?
> I think which locale provider adapters are implemented (and enabled)
> depends on each JRE's implementation, not the spec. However, since this
> is going to change Oracle's JRE behavior (even from yet released jdk8
> beta builds), I will file a CCC request for this.
> Anyway, I think I'll need to split this review request into two. Will do
> it shortly.
>> On 2/23/2013 6:15 AM, Naoto Sato wrote:
>>> Please review the changes for the following CR:
>>> 8004240 : Return value from getAdapterPrefence() can be modified
>>> 8008577 : Enable CLDR LocaleProviderAdapter by default
>>> The webrev is located at:
More information about the i18n-dev