<i18n dev> [8]Request for review - 8008576: Calendar mismatch using Host LocaleProviderAdapter

Masayoshi Okutsu masayoshi.okutsu at oracle.com
Mon Mar 11 00:47:13 PDT 2013

Here are my review comments.

- The Calendar.createCalendar comment says, "but it's not possible since 
JapaneseImperialCalendar is package private." If Calendar.Builder 
doesn't work, should the reason be different? Otherwise, the host locale 
adapters won't be able to create a JapaneseImperialCalendar, either.

- When building a Calendar with Calendar.Builder, the current time needs 
to be set (.setInstant(System.currentMillis())).

- The usage of term "POSIX locale" in Mac OS sounds strange. POSIX 
locale means C locale...

Otherwise, the change looks good to me.


On 3/9/2013 8:45 AM, Naoto Sato wrote:
> Hello,
> Please review the changes for the following CR:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008576
> Here is the webrev for the changes:
> http://cr.openjdk.java.net/~naoto/8008576/webrev.00/
> The gist of the changes is to instantiate a calendar instance using 
> the new Calendar.Builder class that suits the underlying OS's calendar 
> for the current user's locale.
> Naoto

More information about the i18n-dev mailing list