<i18n dev> Request for review - 8008576: Calendar mismatch using Host LocaleProviderAdapter
naoto.sato at oracle.com
Mon Mar 11 16:04:41 PDT 2013
Thank you for the review. Please find my comments below:
On 3/11/13 12:47 AM, Masayoshi Okutsu wrote:
> Here are my review comments.
> - The Calendar.createCalendar comment says, "but it's not possible since
> JapaneseImperialCalendar is package private." If Calendar.Builder
> doesn't work, should the reason be different? Otherwise, the host locale
> adapters won't be able to create a JapaneseImperialCalendar, either.
The code intended to use the same code path for JRE as before, but on
second thought, there is no reason not to use Calendar.Builder() even
for JRE. Modified the fix as such.
> - When building a Calendar with Calendar.Builder, the current time needs
> to be set (.setInstant(System.currentMillis())).
> - The usage of term "POSIX locale" in Mac OS sounds strange. POSIX
> locale means C locale...
Right. But that's not under our control :-)
Revised webrev is located at:
> Otherwise, the change looks good to me.
> On 3/9/2013 8:45 AM, Naoto Sato wrote:
>> Please review the changes for the following CR:
>> Here is the webrev for the changes:
>> The gist of the changes is to instantiate a calendar instance using
>> the new Calendar.Builder class that suits the underlying OS's calendar
>> for the current user's locale.
More information about the i18n-dev