<i18n dev> RFR: 8158272 & 8158468 (tools/jlink/plugins/IncludeLocalesPluginTest.java bug fixes)

Mandy Chung mandy.chung at oracle.com
Fri Jun 10 20:53:25 UTC 2016

> On Jun 10, 2016, at 12:08 AM, Masayoshi Okutsu <masayoshi.okutsu at oracle.com> wrote:
> (re-sending to include jigsaw-dev)
> Hi,
> Please review fixes for 8158272 and 8158468. The test had several problems.
> :
> Webrev:
> http://cr.openjdk.java.net/~okutsu/9/8158272.8158468/webrev.00

It’s good that you replace the hard-coded list of all available locales.  Is it possible to build the golden data programmatically to avoid hardcoding it?

As Alan already suggests, you should consider using ProcessTools testlibrary that will launch the child process with the options specified in jtreg command.

Otherwise looks okay.


More information about the i18n-dev mailing list