<i18n dev> RFR: 8158272 & 8158468 (tools/jlink/plugins/IncludeLocalesPluginTest.java bug fixes)

Mandy Chung mandy.chung at oracle.com
Mon Jun 13 15:02:38 UTC 2016

> On Jun 12, 2016, at 11:10 PM, Masayoshi Okutsu <masayoshi.okutsu at oracle.com> wrote:
> On 6/11/2016 5:53 AM, Mandy Chung wrote:
>>> On Jun 10, 2016, at 12:08 AM, Masayoshi Okutsu <masayoshi.okutsu at oracle.com> wrote:
>>> (re-sending to include jigsaw-dev)
>>> Hi,
>>> Please review fixes for 8158272 and 8158468. The test had several problems.
>>> :
>>> Webrev:
>>> http://cr.openjdk.java.net/~okutsu/9/8158272.8158468/webrev.00
>> It’s good that you replace the hard-coded list of all available locales.  Is it possible to build the golden data programmatically to avoid hardcoding it?
> I think that's possible, but it'll take time to develop it. I hope SQE will develop a better test.

OK.  It’d be good to file a JBS issue for it.

>> As Alan already suggests, you should consider using ProcessTools testlibrary that will launch the child process with the options specified in jtreg command.
> I took a look at ProcessTools, but it doesn't seem to be very convenient for this test to use ProcessTools because the test needs to run java in the image produced by each jlink run. Do you think subprocesses created by the main test need to use jtreg options?

I see.  I’m fine with what you have.  We should enhance the jlink testlibrary to run java from a run-time image created for a test to run.  


More information about the i18n-dev mailing list