<i18n dev> Request for Review : JDK-8071929 -Locale.getISOCountries() has inconsistent behaviour for "AN", "BU" and "CS" country codes.

Rachna Goel rachna.goel at oracle.com
Wed Nov 30 09:31:57 UTC 2016

Hi Stephen,

Thanks a lot for the review.

On 30/11/16 3:15 AM, Stephen Colebourne wrote:
> I'm concerned that this is not the friendliest of new APIs. There is
> little description of the meaning of the ISO-3166 parts - what is
> being added is directly exposing the underlying data rather than
> providing any kind of abstraction.
Could you throw more light on this? Country code data is already 
encapsulated, and there is no direct reference to map accessing those data.
If you have some suggestions on improving it, kindly share.
> There is also an inconsistency between "ISO" and "Iso" in the class/method names.
There has been lot of discussion regarding "ISO" and "Iso". CCC has 
suggested use of "IsoCountryCode" for enum name which I proposed to be 
"ISOCountrycode" .

I have tried to keep constants as "ISO", variables as "iso" as per with 
JDK naming conventions. But Locale class has methods names with  "ISO", 
So I think I will update all internal method names to have "ISO".


> Stephen
> On 29 November 2016 at 09:07, Rachna Goel<rachna.goel at oracle.com>  wrote:
>> Hi,
>> Please review fix for JDK-8071929.
>> Bug :https://bugs.openjdk.java.net/browse/JDK-8071929
>> patch :http://cr.openjdk.java.net/~rgoel/JDK_8071929/webrev.02/
>> Fix is to remove obsolete country code "AN" and provide support for
>> retrieving of ISO3166-1 alpha-2,  ISO3166-1 alpha-3, ISO3166-3 country
>> codes.
>> Thanks,
>> Rachna

More information about the i18n-dev mailing list