<i18n dev>  RFR: 8189272 & 8189291
mandy.chung at oracle.com
Tue Oct 24 00:48:02 UTC 2017
On 10/20/17 5:05 PM, Naoto Sato wrote:
> Hi Mandy,
> Thanks for the review. Webrevs updated as suggested:
DEFAULT_POLICY in test/jdk/java/util/logging/* tests can be moved to the
enclosing class as suggested.
Other than that, the change looks good.
> On 10/20/17 2:45 PM, mandy chung wrote:
>> On 10/20/17 2:20 PM, Naoto Sato wrote:
>>> Please review the changes for the following two issues:
>>> 8189272: CLDR and JRE LocaleProviderAdapters silently swallow
>>> exceptions 
>>> 8189291: Test policy should extend the default system policy 
>>> The proposed fixes for the above issues are located below,
>> Looks fine. The installed providers are our implementation and
>> silently ignore any exception would make it really hard to diagnose
>> problems. This change will help the diagnosability.
>> If the default policy is not cached early before any test policy is
>> constructed, the test might get the wrong Policy object set by the
>> test previously (for example, if it runs in agentvm mode). It would
>> be more reliable if this is cached as the static field in the test
>> class (i.e. the enclosing class of the policy subclass) - like
>> - I think the test fix should be part of JDK-8189272, right?
>>> The fix to 8189272 will throw exceptions that were swallowed in
>>> those providers, which should not happen in proper environment. That
>>> fix makes test cases with security manager fail. The fix to 8189291
>>> addresses it.
>>>  https://bugs.openjdk.java.net/browse/JDK-8189272
>>>  https://bugs.openjdk.java.net/browse/JDK-8189291
More information about the i18n-dev