<i18n dev> Fwd: Re: RFR: 8212794 IBM-964 and IBM-29626C are required for AIX default charset
takiguc at linux.vnet.ibm.com
Wed Nov 14 18:20:20 UTC 2018
I'm very sorry for your confusion, please ignore previous mail.
I posted it on wrong mailing list.
On 2018-11-15 03:11, Ichiroh Takiguchi wrote:
> Martin Buchholz suggested me via bugs.openjdk.java.net,
> I should not touch non AIX side.
> So I rewrote another code.
> Could you review the fix again ?
> Bug: https://bugs.openjdk.java.net/browse/JDK-8212794
> Change: https://cr.openjdk.java.net/~itakiguchi/8212794/webrev.01/
> I don't want to touch non AIX side code, but I need to rename 3 files
> to avoid compilation issue.
> IBM33722.java -> IBM33722.java.template
> IBM964.java -> IBM964.java.template
> SimpleEUCEncoder.java -> SimpleEUCEncoder.java.template
> Ichiroh Takiguchi
> IBM Japan, Ltd.
> -------- Original Message --------
> Subject: Re: RFR: 8212794 IBM-964 and IBM-29626C are required for AIX
> default charset
> Date: 2018-11-08 20:13
> From: Volker Simonis <volker.simonis at gmail.com>
> To: Ichiroh Takiguchi <takiguc at linux.vnet.ibm.com>
> Cc: Java Core Libs <core-libs-dev at openjdk.java.net>,
> ppc-aix-port-dev at openjdk.java.net, "SHEN, XUEMING"
> <xueming.shen at oracle.com>, Alan Bateman
> <Alan.Bateman at oracle.com>
> Hi Ichiroh,
> sorry, but unfortunately, this change is way beyond my level of
> expertise :)
> You should try to get a review from Sherman or Alan.
> On Fri, Oct 26, 2018 at 3:33 PM Ichiroh Takiguchi
> <takiguc at linux.vnet.ibm.com> wrote:
>> Could you review the fix ?
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8212794
>> Change: https://cr.openjdk.java.net/~itakiguchi/8212794/webrev.00/
>> I'd like to obtain a sponsor for this issue.
>> IBM964 charset and IBM29626C charset are required for default charset
>> on AIX zh_TW and ja_JP locale.
>> OpenJDK already has IBM964, but it could not be configured for default
>> IBM29626C is new one.
>> (IBM33722 extends IBM29626C class)
>> I knew IBM charsets would need to move to somewhere.
>> The discussion was started by "Adding new IBM extended charsets". 
>> But it's related default charset issue.
>> Please put them inside of OpenJDK.
>> About IBM964,
>> Bhaktavatsal started the discussion .
>> Sherman said that 
>> the new model (open/make/data/charetmapping), instead of
>> the map
>> into the source code.
>> This fix only has small sized hard-coded mapping,
>> IBM964/IBM29626C/IBM33722 refer other charsets conversion table
>> which are using the new model.
>> And class file is smaller then before.
>> Still I used SimpleEUCEncoder class because it's stable.
>> I think we may re-write it by IBM charsets renewal.
>> Ichiroh Takiguchi
>> IBM Japan, Ltd.
More information about the i18n-dev