<i18n dev> [15]: RFR: 8244245: localizedBy() should override localized values with default values

naoto.sato at oracle.com naoto.sato at oracle.com
Thu May 7 16:03:43 UTC 2020

Hi Joe,

Thank you for the review. The removed check was explicitly avoiding the 
default chrono/number in the locale overriding the current locale 
values, which is exactly what this issue is trying to remove. As Stephen 
wrote in another email, Unicode Extensions are correctly dealt in 
Chronology.ofLocale()/DecimalStyle.of() methods indirectly, so I believe 
no doc change is warranted.


On 5/6/20 11:32 PM, Joe Wang wrote:
> Hi Naoto,
> The Javadoc states:
>      If the locale contains the "ca" (calendar), "nu" (numbering 
> system), "rg" (region override), and/or "tz" (timezone) Unicode 
> extensions, the chronology, numbering system and/or the zone are 
> overridden.
> If you remove the two statements that check whether the specified locale 
> contains "ca" or "nu", would you need to update the Javadoc as well?
> Best,
> Joe
> On 5/6/2020 1:44 PM, naoto.sato at oracle.com wrote:
>> Hello,
>> Please review the fix to the following issue:
>> https://bugs.openjdk.java.net/browse/JDK-8244245
>> The CSR and proposed changeset are located at:
>> https://bugs.openjdk.java.net/browse/JDK-8244246
>> https://cr.openjdk.java.net/~naoto/8244245/webrev.00/
>> This stems from the closed issue 
>> (https://bugs.openjdk.java.net/browse/JDK-8243162), and the rationale 
>> for this fix is discussed there.
>> Naoto

More information about the i18n-dev mailing list