From maurizio.cimadamore at oracle.com Thu Sep 3 15:48:58 2020 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Thu, 3 Sep 2020 16:48:58 +0100 Subject: RFR: JDK-8251193 bin/idea.sh generating wrong source folders for JVMCI modules In-Reply-To: References: Message-ID: <42d1ce63-9eac-fe26-40c0-fa77aa770147@oracle.com> Sorry for the delay, overall this looks like a good improvement, so I'll approve. Is there some colleague that can help you do the push? Let me know if you need help. Thanks Maurizio On 06/08/2020 15:28, Galder Zamarreno wrote: > Hi, > > `bin/idea.sh` is not generating the right source folders for > jdk.internal.vm.ci and jdk.internal.vm.compiler modules. > > These modules have different directory structures to the rest and so should > be handled exceptionally so that the IDE has the right source folder > definitions. > > The fix takes these two modules, inspects all the subdirectories within > each module root and generates a source folder definition for each. As > example, for jdk.internal.vm.ci, there should be a source folder for: > > * src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.aarch64/src > * src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.amd64/src > * ... > > I've tested this in the patch on IDEA 2020.2. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8251193 > WebRev: > http://cr.openjdk.java.net/~sgehwolf/webrevs/galder/JDK-8251193/01/webrev/ > > Galder From sgehwolf at redhat.com Mon Sep 7 16:00:13 2020 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Mon, 07 Sep 2020 18:00:13 +0200 Subject: RFR: JDK-8251193 bin/idea.sh generating wrong source folders for JVMCI modules In-Reply-To: <42d1ce63-9eac-fe26-40c0-fa77aa770147@oracle.com> References: <42d1ce63-9eac-fe26-40c0-fa77aa770147@oracle.com> Message-ID: <1a467c1d4ae99a12cc88cf372e121b6ae917e58a.camel@redhat.com> Hi, On Thu, 2020-09-03 at 16:48 +0100, Maurizio Cimadamore wrote: > Sorry for the delay, > overall this looks like a good improvement, so I'll approve. > > Is there some colleague that can help you do the push? > > Let me know if you need help. I'll sponsor the patch for Galder. Yet, sponsoring with git works differently now. Maurizio: I guess approving this PR would be sufficient? https://github.com/openjdk/jdk/pull/63 Thanks, Severin > Thanks > Maurizio > > On 06/08/2020 15:28, Galder Zamarreno wrote: > > Hi, > > > > `bin/idea.sh` is not generating the right source folders for > > jdk.internal.vm.ci and jdk.internal.vm.compiler modules. > > > > These modules have different directory structures to the rest and so should > > be handled exceptionally so that the IDE has the right source folder > > definitions. > > > > The fix takes these two modules, inspects all the subdirectories within > > each module root and generates a source folder definition for each. As > > example, for jdk.internal.vm.ci, there should be a source folder for: > > > > * src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.aarch64/src > > * src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.amd64/src > > * ... > > > > I've tested this in the patch on IDEA 2020.2. > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8251193 > > WebRev: > > http://cr.openjdk.java.net/~sgehwolf/webrevs/galder/JDK-8251193/01/webrev/ > > > > Galder From maurizio.cimadamore at oracle.com Mon Sep 7 16:15:57 2020 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Mon, 7 Sep 2020 17:15:57 +0100 Subject: RFR: JDK-8251193 bin/idea.sh generating wrong source folders for JVMCI modules In-Reply-To: <1a467c1d4ae99a12cc88cf372e121b6ae917e58a.camel@redhat.com> References: <42d1ce63-9eac-fe26-40c0-fa77aa770147@oracle.com> <1a467c1d4ae99a12cc88cf372e121b6ae917e58a.camel@redhat.com> Message-ID: <0d2b5072-764a-3dd9-351f-1a78ce429bda@oracle.com> I've approved - seems to me that you can now just integrate. (otherwise, I could have just typed "/sponsor" if the author did not have commit rights) Maurizio On 07/09/2020 17:00, Severin Gehwolf wrote: > Hi, > > On Thu, 2020-09-03 at 16:48 +0100, Maurizio Cimadamore wrote: >> Sorry for the delay, >> overall this looks like a good improvement, so I'll approve. >> >> Is there some colleague that can help you do the push? >> >> Let me know if you need help. > I'll sponsor the patch for Galder. Yet, sponsoring with git works > differently now. > > Maurizio: I guess approving this PR would be sufficient? > https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/63__;!!GqivPVa7Brio!IOP7rxQacZCWlIbDaIJWne0Iho8A9heq5mfLqqk8X6X8Wyq2JT_nSFwVsX9gjaaHTxWNjVQ$ > > Thanks, > Severin > > > >> Thanks >> Maurizio >> >> On 06/08/2020 15:28, Galder Zamarreno wrote: >>> Hi, >>> >>> `bin/idea.sh` is not generating the right source folders for >>> jdk.internal.vm.ci and jdk.internal.vm.compiler modules. >>> >>> These modules have different directory structures to the rest and so should >>> be handled exceptionally so that the IDE has the right source folder >>> definitions. >>> >>> The fix takes these two modules, inspects all the subdirectories within >>> each module root and generates a source folder definition for each. As >>> example, for jdk.internal.vm.ci, there should be a source folder for: >>> >>> * src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.aarch64/src >>> * src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.amd64/src >>> * ... >>> >>> I've tested this in the patch on IDEA 2020.2. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8251193 >>> WebRev: >>> http://cr.openjdk.java.net/~sgehwolf/webrevs/galder/JDK-8251193/01/webrev/ >>> >>> Galder