RFR(M): jdk11u-dev backport 8205611: Improve the wording of LinkageErrors to include module and class loader information
martin.doerr at sap.com
Mon May 6 12:40:54 UTC 2019
thanks for backporting.
It would have been much easier to backport the issues in the correct order.
I think you resolved that correctly.
The jdk11u backport of JDK-8212937 diffs from the jdk12u version.
diff -r test/hotspot/jtreg/runtime/LoaderConstraints/ ../jdk12u/test/hotspot/jtreg/runtime/LoaderConstraints/
diff -r test/hotspot/jtreg/runtime/LoaderConstraints/duplicateParentLE/Test.java ../jdk12u/test/hotspot/jtreg/runtime/LoaderConstraints/duplicateParentLE/Test.java
< System.out.println("Expected: " + expectedErrorMessage_part1 + "<id>" + expectedErrorMessage_part2 + "<id>" + expectedErrorMessage_part3 + "\n" +
> System.out.println("Expected: " + expectedErrorMessage_part1 + "<id>" + expectedErrorMessage_part2 + "\n" +
But that's not related to your change.
So your backport change looks good. Reviewed.
From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On Behalf Of Hohensee, Paul
Sent: Freitag, 12. April 2019 19:21
To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; jdk-updates-dev at openjdk.java.net; hotspot-dev at openjdk.java.net
Subject: Re: RFR(M): jdk11u-dev backport 8205611: Improve the wording of LinkageErrors to include module and class loader information
Looks good. I applied the patch and the modified tests pass on my osx laptop.
On 4/11/19, 7:04 AM, "jdk-updates-dev on behalf of Lindenmaier, Goetz" <jdk-updates-dev-bounces at openjdk.java.net on behalf of goetz.lindenmaier at sap.com> wrote:
I would like to backport 8205611. Unfortunately, it does not apply clean,
as 8212937, a fix that came after 8205611, was already downported.
I needed changes at two places:
Deleting obsolete java_lang_ClassLoader::describe_external() does
not apply because 8212937 changed in this function. See
Further the exception message in duplicateParentLE/Test.java had to be adapted.
New webrev for 11u-dev:
The conflicting change in jdk12:
And downported to jdk11:
See also the original review thread:
More information about the jdk-updates-dev