[11u] RFR: 8224474: harfbuzz 2.3.1 code fails to compile with gcc 4.4.7
Andrew John Hughes
gnu.andrew at redhat.com
Tue May 28 22:08:16 UTC 2019
On 21/05/2019 10:33, Severin Gehwolf wrote:
> Could I please get a review for this JDK 11u only fix? harfbuzz has
> been upgraded to 2.3.1 between jdk-11.0.4+2 and jdk-11.0.4+3.
> Unfortunately, this breaks the JDK 11u build on CentOS/RHEL 6 with
> system GCC 4.4.7 which the upstream OpenJDK 11u builds machinery uses.
> The fix is rather trivial: Move GCC pragmas outside functions.
> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8224474/01/webrev/
> bug: https://bugs.openjdk.java.net/browse/JDK-8224474
> Testing: release/slowdebug builds on Linux x86_64 with gcc 4.4.7.
> fastdebug build on Linux x86_64 with gcc 8.3.1
The HarfBuzz update (JDK-8210782) went to 12 & 13 as well. Should this
not go there as well, or do we not want to support this older GCC on > 11?
Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
More information about the jdk-updates-dev