[11u] RFR: 8242154: Backport parts of JDK-4947890 to OpenJDK 11u

Severin Gehwolf sgehwolf at redhat.com
Thu Apr 9 12:12:23 UTC 2020

Hi Christoph,

On Sat, 2020-04-04 at 12:23 +0000, Langer, Christoph wrote:
> Hi,
> please review this partial backport of JDK-4947890 [0] to OpenJDK
> 11u.
> I'm currently working on backporting 8232080: jlink plugins for
> vendor information and command-line options [1]. That patch adds a
> jlink plugin for setting customized values for system properties
> java.vendor.version, java.vendor.url and java.vendor.url.bug in a
> jlinked runtime image by modifying the bytecode of class
> java.lang.VersionProps. Amongst other things, JDK-4947890 created the
> foundation for this patch by moving the initialization of
> java.vendor.url and java.vendor.url.bug to java.lang.VersionProps.
> Before, it was initialized in libjava's System.c. While it's not
> desirable to backport JDK-4947890 as a whole to 11u, I'd like to
> bring in the part that moves initialization of java.vendor,
> java.vendor.url and java.vendor.url.bug to java.lang.VersionProps.
> Since it's only a part of the original JDK-4947890, I created the new
> JDK11 specific bug JDK- 8242154.


> Bug: https://bugs.openjdk.java.net/browse/JDK-8242154
> Original change of JDK-4947890: http://hg.openjdk.java.net/jdk/jdk/rev/0bdbf854472f
> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8242154.11u.0/

in System.c:

-    PUTPROP(props, "java.version", VERSION_SHORT);
-    PUTPROP(props, "java.vendor", VENDOR);
-    PUTPROP(props, "java.vendor.url", VENDOR_URL);
-    PUTPROP(props, "java.vendor.url.bug", VENDOR_URL_BUG);

Aren't you removing "PUTPROP(props, "java.version", VERSION_SHORT)";
too eagerly here?



> [0] https://bugs.openjdk.java.net/browse/JDK-4947890
> [1] https://bugs.openjdk.java.net/browse/JDK-8232080

More information about the jdk-updates-dev mailing list