[11u] RFR: 8234149: Several regression tests do not dispose Frame at end
goetz.lindenmaier at sap.com
Tue Jun 9 17:10:23 UTC 2020
Thanks for reviewing my change.
* @key headful
As far as I know many tests in jdk/jdk lack the headful tag.
In 11u there are even more, because changes introducing
the tag in head are not all downported.
When I added these tags to many tests, I tried to find all
that cause problems if they are run in a headless environment.
While I think fixing any test wrt. to the tag is useful, I'm
not sure it's worth the effort to do it for a single test.
From: Baesken, Matthias <matthias.baesken at sap.com>
Sent: Tuesday, June 9, 2020 1:56 PM
To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; 'jdk-updates-dev at openjdk.java.net' <jdk-updates-dev at openjdk.java.net>
Subject: RE: [11u] RFR: 8234149: Several regression tests do not dispose Frame at end
Hello Goetz , looks good to me .
While looking at all those files , I noticed that
(btw same for test/jdk/javax/swing/JFrame/8037575/bug8037575.java )
Looks like test/jdk/javax/swing/JFrame/8037575/bug8037575.java still has no key headful in jdk/jdk while bug4962534.java got it ...
Should I open a bug for test/jdk/javax/swing/JFrame/8037575/bug8037575.java ?
Best regards, Matthias
From: Lindenmaier, Goetz <goetz.lindenmaier at sap.com<mailto:goetz.lindenmaier at sap.com>>
Sent: Freitag, 5. Juni 2020 13:14
To: 'jdk-updates-dev at openjdk.java.net' <jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>>
Subject: [11u] RFR: 8234149: Several regression tests do not dispose Frame at end
I am downporting this for 11.0.9-oracle parity.
I had to resolve a row of files:
bug4796987.java: OS check in context different, easy resolve.
bug6596966.java: simple resolve. Indented code differs again in os check.
bug6470128.java, bug6580930.java, bug6827786.java, bug4202954.java, bug4624207.java
all similar indentation issues.
bug4962534.java, bug4634626.java: main method being fixed is only in 15
because "8213110: Remove the use of applets in automatic tests" is not in 11.
I just copied the whole main method. This way these fixes can not
be overseen in case 8213110 is brought to 11 at some point.
More information about the jdk-updates-dev