[13u] RFR 8233787: Break cycle in vm_version* includes

Yuri Nesterenko yan at azul.com
Tue Jun 30 09:31:42 UTC 2020

Looks good to me.


On 30.06.2020 11:55, Vladimir Kempik wrote:
> Hello
> Please review this backport of JDK-8233787 to jdk13u
> The patch didn’t apply cleanly, the changes between original path and backport includes:
> 1) included headers names around changed lines here and there, nothing interesting
> 2)  src/hotspot/share/runtime/vm_version.cpp and  src/hotspot/share/runtime/vm_version.hpp.
> this change moves most of vm_version.[ch]pp to abstract_vm_version.[ch]pp, but vm_version files was
> slightly different in original changeset.
> I have moved content of vm_version to abstract_vm_version carefully to make it match 13u files.
> Testing: tier1, tier2.
> The bug: https://bugs.openjdk.java.net/browse/JDK-8233787
> The webrev: http://cr.openjdk.java.net/~vkempik/8233787/webrev.13u.00/
> Original review thread: https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-November/039904.html
> Thanks, Vladimir

More information about the jdk-updates-dev mailing list