[11u] RFR: 8213483: ARM32: runtime/ErrorHandling/ShowRegistersOnAssertTest.java jtreg test fail
shade at redhat.com
Thu Apr 22 09:50:13 UTC 2021
On 4/22/21 11:37 AM, Christoph Göttschkes wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8213483
> Original commit: https://git.openjdk.java.net/jdk/commit/bca9e55b
> Webrev: https://cr.openjdk.java.net/~cgo/8213483/webrev.11u.00/
It was on my plate to backport, so I am glad to see you handling this :)
This looks good, with one minor nit: src/hotspot/share/utilities/breakpoint.hpp changes the
copyright year to 2020, your webrev should follow suit. In other words, do not change the copyright
header beyond what the patch does.
> Because it is a tier1 test, I think it is more important to have the test
> pass, than to have the hardware breakpoint available, which might make it easier
> to debug certain problems, but can always be added by the developer if needed.
> The commit is also marked to solve 8253167 (https://bugs.openjdk.java.net/browse/JDK-8253167) as well,
> but this is not a problem in 11u. Should I, if the review is OK and I can tag for approval,
> tag both bugs and wait for the approval of both?
Yes, that is the way, I think. Mention that in fix request, something along the lines of "This bug
does not technically affect 11u yet, but the changeset for JDK-8213483 backport mentions it. Marking
for 11u approval too."
More information about the jdk-updates-dev