[Ping] Re: Request for Approval: Backport of 8146792 : Predicate moved after partial peel may lead to broken graph

Yangfei (Felix) felix.yang at huawei.com
Wed Aug 7 11:42:10 UTC 2019

I saw your approval flag in the bug database, but there was no mention of whether the patch applied cleanly or not. I see no webrev link either there or in this e-mail. Can you clarify what you mean by "almost clean"
or maybe just provide a webrev for review?


    Sorry, I should have sent the webrev in my first e-mail.


    The only difference: the following change from the original patch is not needed as it is already there in the 8u repo.

--- src/share/vm/opto/loopPredicate.cpp Tue Jan 12 10:44:41 2016 -1000
+++ src/share/vm/opto/loopPredicate.cpp Mon Jan 11 16:02:42 2016 +0100
@@ -665,6 +689,7 @@

   if (scale != 1) {
     ConNode* con_scale = _igvn.intcon(scale);
+    set_ctrl(con_scale, C->root());
     max_idx_expr = new MulINode(max_idx_expr, con_scale);
     register_new_node(max_idx_expr, ctrl);
     if (TraceLoopPredicate) predString->print("* %d ", scale);


More information about the jdk8u-dev mailing list