[8u] RFR 8229501: jdk/test/lib/testlibrary/ClassFileInstaller.java should match hotspot//test/testlibrary version

Verghese, Clive verghese at amazon.com
Fri Aug 23 17:43:13 UTC 2019

Hi Andrew Hughes, 

Thank you for the detailed feedback, I will update the webrev with the bug id's.  

Clive Verghese

On 8/21/19, 8:58 AM, "Andrew John Hughes" <gnu.andrew at redhat.com> wrote:

    On 13/08/2019 23:12, Verghese, Clive wrote:
    > Hi,
    > Requesting review for webrev : http://cr.openjdk.java.net/~phh/8229501/webrev.8u.00/
    > JBS Issue : https://bugs.openjdk.java.net/browse/JDK-8229501
    > Email discussion : https://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-August/010029.html
    > hotspot/test/testlibrary/ClassFileInstaller.java and jdk/test/lib/testlibrary/ClassFileInstaller were merged as part of the JDK10 repo merge. For 8u, we should sync the JDK version with the Hotspot version in order to facilitate backports of patches such as the one for JDK-8216401<https://bugs.openjdk.java.net/browse/JDK-8216401> that assume the merged version.
    > Testing
    >                 Validated that the test depending on ClassFileInstaller pass.
    > Regards,
    > Clive Verghese
    This appears to just be the result of:
    $ diff -u hotspot/test/testlibrary/ClassFileInstaller.java
    I don't think a code dump with a unique bug ID is the correct way to fix
    The actual changes come from two HotSpot changes:
    changeset:   8710:4141ef4c8ba8
    user:        vaibhav
    date:        Thu Jul 26 06:16:09 2018 -0400
    summary:     8189762: [TESTBUG] Create tests for JDK-8146115 container
    awareness and resource configuration
    changeset:   4665:43083e670adf
    user:        coleenp
    date:        Mon May 13 15:37:08 2013 -0400
    summary:     8005056: NPG: Crash after redefining java.lang.Object
    The appropriate course of action here is to apply the
    test/testlibrary/ClassFileInstaller.java changes from these changesets
    to the copy under test/lib/testlibrary/ClassFileInstaller.java under
    their appropriate bug IDs, as should have been done to begin with and, I
    presume, is intended for future changes to keep these in sync. This then
    associates the changes with their original review and motivation.
    I just tried this with 8189762 and it applies cleanly, leaving just the
    changes in 8005056 as the diff.
    I'd prefer they were separate changesets, but the current webrev could
    be used with these two bug IDs rather than 8229501.
    Andrew :)
    Senior Free Java Software Engineer
    Red Hat, Inc. (http://www.redhat.com)
    PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
    Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

More information about the jdk8u-dev mailing list