[8u] RFR: 8195153: [test] runtime/6981737/Test6981737.java shouldn't check 'java.vendor' and 'java.vm.vendor' properties
gnu.andrew at redhat.com
Fri Mar 1 19:46:01 UTC 2019
On Fri, 1 Mar 2019 at 16:12, Severin Gehwolf <sgehwolf at redhat.com> wrote:
> Could somebody please review this 8u backport for a test which checks
> the java.vendor and java.vm.vendor property? The JDK 8 patch is the
> same as JDK 10's version modulo contextual changes and reshuffeling.
> the JDK 10 patch does not apply cleanly because there is no
> Runtime.version() in JDK 8 (that is part of the patch context).
> Bug: https://bugs.openjdk.java.net/browse/JDK-8195153
> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8195153/jdk8/01/webrev/
> Testing: Test fails with AdoptOpenJDK's JDK 8 build, and passes after
> the fix.
Looks good to me.
I think we also need https://bugs.openjdk.java.net/browse/JDK-8189761 to make
this really worthwhile.
Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Web Site: http://fuseyism.com
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
More information about the jdk8u-dev