[PATCH] [8u] Prevent MSDOS8.3 named DLL in built image

Ali Ince ali.ince at gmail.com
Thu Mar 28 19:47:56 UTC 2019

Hi All,

We're working on building JDK8U with VS2017 at AdoptOpenJDK and found out that the new vcruntime140.dll is copied to the built image named as `vcrunt~1.dll` which is basically because of the extra call to `BASIC_FIXUP_PATH` call in `toolchain_windows.m4` file. If the call is removed, everything works fine.

On previous versions of VS, the VC runtime DLL was originally named in 8.3 style (ex. msvcr100.dll) and BASIC_FIXUP_PATH did not have any affect on the file name itself. I've checked with `toolchain_windows.m4` files in jdk11u and onwards and also saw that this call doesn't exist.

I've came up with the following patch which removes this call. I'm not sure what's the process about updating the checked-in generated_configure.sh but I could also add the patch for that if it's required.

Let me know if you have any feedback or comments.




diff -r e0b7721459ee common/autoconf/toolchain_windows.m4
--- a/common/autoconf/toolchain_windows.m4    Wed Mar 20 16:32:54 2019 +0000
+++ b/common/autoconf/toolchain_windows.m4    Thu Mar 28 00:03:10 2019 +0000
@@ -493,7 +493,6 @@
     if $ECHO "$MSVC_DLL_FILETYPE" | $GREP "$CORRECT_MSVCR_ARCH" 2>&1 > /dev/null; then

More information about the jdk8u-dev mailing list