[8u] RFR 8254631: Better support ALPN byte wire values in SunJSSE

Martin Balao mbalao at redhat.com
Thu Apr 22 19:14:47 UTC 2021


I'd like to request a review for the 8u backport of JDK-8254631 [1].



The 11u patch does not apply cleanly because of the following reasons:

 * Paths need to be converted to the old scheme

 * java.security changes need to be propagated through the different
java.security-<os> files

 * AlpnGreaseTest.java uses a java.util.Arrays public API not available
in 8u (introduced by JDK-8033148 [2]).
  * Fixed creating copies of the arrays to compare.

 * AlpnGreaseTest.java uses ByteBuffer::flip that returns a ByteBuffer.
In 8u JDK-4774077 [3] is not present so Buffer::flip gets called and a
Buffer is returned. This is a problem because ::get(byte[]) is then
invoked and this is not available in the Buffer class (but in ByteBuffer).
  * Fixed with a simple casting.

No test regressions found in jdk/sun/security/ssl.


[1] - https://bugs.openjdk.java.net/browse/JDK-8254631
[2] - https://bugs.openjdk.java.net/browse/JDK-8033148
[3] - https://bugs.openjdk.java.net/browse/JDK-4774077

More information about the jdk8u-dev mailing list