[8u] RFR bad source/target in Makefile of J2DBench

Andrew Hughes gnu.andrew at redhat.com
Mon Oct 25 13:37:04 UTC 2021

On 18:56 Thu 21 Oct     , Jiri Vanek wrote:
> http://cr.openjdk.java.net/~jvanek/bad_j2d_bytecodeversion/
> Hello! the build.xml (https://hg.openjdk.java.net/jdk8u/jdk8u/jdk/file/d2bbff5b7006/src/share/demo/java2d/J2DBench/build.xml#l52) is corerect,
> and have -source/target correctly on 1.5
> However Mkaefile was left behind, and is on 1.2, which jdk8 itself can not play.
> Am looking forward for kind soul to create a bug a commit on my behalf.
> Happy hacking,
>     J.
> -- 
> Jiri Vanek Mgr.
> Principal QA Software Engineer
> Red Hat Inc.
> +420 775 39 01 09

This looks like a subset of:


I think it would be preferable to backport this to keep this code aligned
across JDKs. It fixes some other differences between the Makefile &
build.xml, as well as actually making it buildable with 1.4, as the
README claims.

The -g:none addition seemed strange to me, but it seems debug=false
has been in build.xml since the start of the OpenJDK project [0].
If we want to remove that, we should probably do so in HEAD and
backport for consistency across releases.

[0] https://mail.openjdk.java.net/pipermail/2d-dev/2014-August/004736.html
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

More information about the jdk8u-dev mailing list