Review Request: JDK-8173374: Update GenGraphs tool to generate dot graph with requires transitive edges

Daniel Fuchs daniel.fuchs at
Wed Feb 15 18:29:13 UTC 2017

Hi Mandy,

Some early comments:

   58                 dir = Paths.get(args[++i]);

may produced ArrayOutOfBoundsException - should we have better
error reporting?
Or should it check && i < args.length - 1 so that it falls back
to having dir == null below?


could that be: .resolve(finder,

  119         return;
  277             this.nodes.addAll(nodes);

These were bugs, which you're taking this opportunity to fix - right?

1027                 // print module descriptor

Is this comment accurate?

Missing @bug tag?

best regards,

-- daniel

On 15/02/17 00:28, Mandy Chung wrote:
> This is the first step to enable generating dot graph to be
> included in module summary javadoc, if desired.  jdeps already
> supports generating the dot graph for modules.  This patch
> converts GenGraphs build tool to use jdeps implementation
> as well as fixes jdeps to work with -apionly to generate
> a dot graph containing `requires transitive` edges only.
> Mandy
> [1]

More information about the jigsaw-dev mailing list