RFR 8172527: Rename jdk.crypto.token to jdk.crypto.cryptoki

Bradford Wetmore bradford.wetmore at oracle.com
Thu Jan 19 22:13:32 UTC 2017

Similar problem about the rename.  rename or addremove (likely) should 
work, but hg add/hg remove won't.

To check that all references to jdk.crypto.{token,pkcs11} are gone, I 
ran a test over lunch and applied the webrev patches to a clean 
workspace.  There was a problem applying the jdk webrev via gpatch on 
Solaris.  This may be a bug in gpatch or pilot error, but please check 
it out.

patching file 
Reversed (or previously applied) patch detected!  Assume -R? [n]

Then at the end of the gpatch, these files were left in the directory.

P11Signature.java       P11Signature.java.orig  P11Signature.java.rej

Otherwise, everything seems to be fine.


On 1/19/2017 11:50 AM, Mandy Chung wrote:
>> On Jan 19, 2017, at 11:39 AM, Anthony Scarpino <anthony.scarpino at oracle.com> wrote:
>> Hi,
>> I need a review to rename the jdk.crypto.token to jdk.crypto.cryptoki. This is to change what 8171202 had done to the original jdk.crypto.pkcs11 module.  For those not familiar with discussions elsewhere, the term "token" is confusing and unclear as it can mean many things cryptographically.  The use of cryptoki is more accurate to the original 'pkcs11' name and still conforming to the new naming standard.
>> http://cr.openjdk.java.net/~ascarpino/8172527/webrev-root/
>> http://cr.openjdk.java.net/~ascarpino/8172527/webrev-jdk/
> The webrev shows deleted/new files for src/jdk.crypto.token source files rather than rename.  Did you use hg rename?
> Changes in other files looks good.
> Mandy

More information about the jigsaw-dev mailing list